Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/send host name update #76

Merged
merged 5 commits into from
Oct 19, 2018
Merged

Feat/send host name update #76

merged 5 commits into from
Oct 19, 2018

Conversation

jinwoo-kim-nhn
Copy link
Contributor

  • ga 공지 및 request 메서드를 sendHostname으로 수정

@jinwoo-kim-nhn
Copy link
Contributor Author

ok to test

seonim-ryu
seonim-ryu reviewed Oct 19, 2018
View reviewed changes
README.md Outdated
var imageEditor = new tui.ImageEditor('#tui-image-editor-container', options);
```

Or, include tui-code-snippet(**v1.4.0** or **later**) and then immediately write the options as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 코드 스니펫 리포 링크 달아주면 좋을 것 같아요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정하였습니다

seonim-ryu
seonim-ryu reviewed Oct 19, 2018
View reviewed changes
README.md Outdated
Or, include tui-code-snippet(**v1.4.0** or **later**) and then immediately write the options as follows:

```js
tui.usageStatistics = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탭 공백 제거하면 좋겠습니다ㅎ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵

@seonim-ryu
Copy link
Member

[10/19] 리뷰 완료하였습니다.

@jinwoo-kim-nhn jinwoo-kim-nhn merged commit bae6855 into master Oct 19, 2018
@junghwan-park junghwan-park deleted the feat/sendHostNameUpdate branch January 30, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seonim-ryu seonim-ryu seonim-ryu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinwoo-kim-nhn @seonim-ryu