Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrected undo rotate angle for undo action (fixed #307) #309

Merged
merged 8 commits into from
Jan 30, 2020
Merged

fix: incorrected undo rotate angle for undo action (fixed #307) #309

merged 8 commits into from
Jan 30, 2020

Conversation

jinwoo-kim-nhn
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn commented Jan 23, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

issue

원인

  • undo 스택에 저장시 undoData가 변경전 angle값을 가지고 있어야 값을 되돌릴수 있는데..
  • undoData.angle이 마지막 변경후의 마지막 angle을 갖고 저장이 되므로 값이 되돌려 지지 않음 (현재 angle과 이전 상태의 angle이 같은 값으로 저장됨)

해결

  • rotation의 마지막 스택의 angle 값을 항상 알고 있도록 변경하고, 그 값을 기준으로 동작 하도록 변경

@jinwoo-kim-nhn jinwoo-kim-nhn changed the base branch from master to feat/changeInputBindig January 23, 2020 08:33
@jinwoo-kim-nhn jinwoo-kim-nhn changed the title Fix/incorrected undo angle for undo data Fix/incorrected undo angle for undo data (fixed #307) Jan 23, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn changed the base branch from feat/changeInputBindig to master January 28, 2020 06:23
@jinwoo-kim-nhn jinwoo-kim-nhn changed the title Fix/incorrected undo angle for undo data (fixed #307) fix: incorrected undo rotate angle for undo action (fixed #307) Jan 30, 2020
junghwan-park
junghwan-park approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료입니다!

@jinwoo-kim-nhn jinwoo-kim-nhn merged commit a183b4f into master Jan 30, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn deleted the fix/incorrectedUndoAngleForUndoData branch March 20, 2020 08:13
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@jinwoo-kim-nhn @HerlinMatos
fix: incorrected undo rotate angle for undo action (fixed nhn#307) (n…
e0b4f3b 
…hn#309)

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* fix: added jsdoc for missing jsdoc

* feat: some refactoring for remove event binding

* fix: rotation setAngle undo bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junghwan-park junghwan-park junghwan-park approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinwoo-kim-nhn @junghwan-park