Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work when running undo on setAngle. #307

Closed
jinwoo-kim-nhn opened this issue Jan 22, 2020 · 0 comments
Closed

Does not work when running undo on setAngle. #307

jinwoo-kim-nhn opened this issue Jan 22, 2020 · 0 comments
Labels
Bug
Milestone
v3.8.0

Comments

@jinwoo-kim-nhn
Copy link
Contributor

jinwoo-kim-nhn commented Jan 22, 2020 •
edited
Loading

Version

3.7.3

Development Environment

mac, chrome

Current Behavior

  • Does not work when running undo on setAngle.

Expected Behavior
@jinwoo-kim-nhn jinwoo-kim-nhn changed the title undo and redo functions do not work properly. Does not work when running undo on setAngle. Jan 23, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn mentioned this issue Jan 23, 2020
Merged
7 tasks
@jinwoo-kim-nhn jinwoo-kim-nhn added this to the v3.8.0 milestone Jan 23, 2020
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@jinwoo-kim-nhn @HerlinMatos
fix: incorrected undo rotate angle for undo action (fixed nhn#307) (n…
e0b4f3b 
…hn#309)

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* fix: added jsdoc for missing jsdoc

* feat: some refactoring for remove event binding

* fix: rotation setAngle undo bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v3.8.0
Development

No branches or pull requests
1 participant
@jinwoo-kim-nhn