fix: incorrected event noti at cropzone (fixed #269) #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoo-kim-nhn
changed the title
7 tasks
jinwoo-kim-nhn
changed the title
dongsik-yoo
reviewed
Jan 28, 2020
src/js/graphics.js
Outdated
|
|
||
| this.fire(events.OBJECT_SCALED, params); | ||
| if (['none', 'registed'].indexOf(eventDelegationRegister) < 0) { |
There was a problem hiding this comment.
eventDelegation함수의 리턴값 타입이 여러 개라서 코드 읽기가 조금 시간이 더 걸리네요. register 기능은 따로 빼는 건 어떠세요?
There was a problem hiding this comment.
넵 따로 빼는게 좋겠네요. 리뷰 감사합니다.
|
[01/28] 수고 많으셨습니다. |
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* fix: incorrected event noti at cropzone * middle commit * refactor: changed to forward event delegation commands only once. * refactor: remove incorrected prams and remove console log * refactor: removed unnessary module at test code * apply codereview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
issue
원인
canvs.on('objectScale')또는canvs.on('objectMoved')이벤트가 일어난 후에 cropzone 객체가 객체의 포지션을 규칙에 맞게(cropzone 영역이 캔버스 영역 밖으로 못 벗어나게) 바꾸어 버림, 사용자는 바뀌기 전의 포지션 정보를 받으므로 오류로 인식하게 됨.해결
캔버스이벤트위임 기능을 가지고 있으면, 이후의 이벤트는 전부 target객체(cropzone)에게 알아서 이벤트 시점에 맞게 이벤트를 발생시키도록 역할 위임