feat: dev config tool update (fix #298) #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jinwoo-kim-nhn 바꾸게된 이유와 변경 내역이 github issue로 PR에 연결되어 관리되면 좋을것 같습니다. |
jinwoo-kim-nhn
changed the title
|
fabric 설치 방법이 바뀐다면 readme에 설명도 바뀌어야 할 것 같습니다! |
junghwan-park
approved these changes
Jan 14, 2020
dongsik-yoo
reviewed
Jan 14, 2020
karma.conf.js
Outdated
| { | ||
| test: /\.js$/, | ||
| include: /src/, | ||
| exclude: /node_modules|bower_components/, |
There was a problem hiding this comment.
I knew wrong usage, bower did not need to excloud. Thank you.
karma.conf.js
Outdated
| test: /\.styl$/, | ||
| loader: 'css-loader!stylus-loader?paths=src/css/' | ||
| use: [ |
There was a problem hiding this comment.
A brief version is use: ['css-loader', 'stylus-loader'].
webpack.config.js
Outdated
| ], | ||
| loaders: [ | ||
| { | ||
| exclude: /node_modules|bower_components/, |
There was a problem hiding this comment.
I knew wrong usage, bower did not need to excloud. OK
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* feat: webpack version up * feat: cssExtract plugin update * feat: karma.conf update middle commit * feat: karma.conf update middle commit * feat: webpack with karma version update middle commit * update package-lock * feat: karma version update 4.x.x * fix: fixed all vulnerabilities at package.json * fix: added mode property webpack config * feat: added dist directory for npm istall test * test complete with delete dist directory * restore un nessary fix point * apply code review at webpack config * fix: fixed fabricjs install guide * fix: fix karma.conf.js for css-loader webpack config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
issue
npm install fails to install normally on nodejs stable version #298
npm install fails to install normally on nodejs stable version
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨