Skip to content

Commit

Permalink
feat: dev config tool update (fix nhn#298) (nhn#295)
Browse files Browse the repository at this point in the history
* feat: webpack version up

* feat: cssExtract plugin update

* feat: karma.conf update middle commit

* feat: karma.conf update middle commit

* feat: webpack with karma version update middle commit

* update package-lock

* feat: karma version update 4.x.x

* fix: fixed all vulnerabilities at package.json

* fix: added mode property webpack config

* feat: added dist directory for npm istall test

* test complete with delete dist directory

* restore un nessary fix point

* apply code review at webpack config

* fix: fixed fabricjs install guide

* fix: fix karma.conf.js for css-loader webpack config
  • Loading branch information
jinwoo-kim-nhn authored and HerlinMatos committed Jul 2, 2020
1 parent 92e1d3a commit ea5a378
Show file tree
Hide file tree
Showing 6 changed files with 9,251 additions and 4,105 deletions.
17 changes: 2 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,22 +191,9 @@ $ npm install --save tui-image-editor # Latest version
$ npm install --save tui-image-editor@<version> # Specific version
```

##### 2. `fabric.js` installation
And you should add **postInstall** script to your `package.json`.
_This process will be removed when `fabric.js` updated to v2.7.0 and bundled with TOAST UI ImageEditor together._
##### 2. If the installation of the `fabric.js` dependency module does not go smoothly

```js
{
// ...
"scripts": {
// ...
"postInstall": "npm install --no-save --no-optional fabric@^1.6.7"
}
// ...
}
```

Or you can add `fabric` as dependency. **But** there is [some steps](https://github.com/fabricjs/fabric.js#install-with-npm) to be installed well.
To solve the problem, you need to refer to [Some Steps](https://github.com/fabricjs/fabric.js#install-with-npm) to solve the problem.

#### bower

Expand Down
35 changes: 18 additions & 17 deletions karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* eslint-disable consts-on-top, no-process-env, require-jsdoc */
/* eslint-disable no-process-env, require-jsdoc */

const webdriverConfig = {
hostname: 'fe.nhnent.com',
port: 4444,
Expand Down Expand Up @@ -121,36 +120,38 @@ module.exports = function(config) {
},
reporters: ['dots'],
webpack: {
mode: 'development',
devtool: 'inline-source-map',
externals: {
fabric: 'fabric'
},
module: {
preLoaders: [
rules: [
{
test: /\.js$/,
include: /src/,
exclude: /node_modules/,
loader: 'eslint-loader',
enforce: 'pre'
},
{
test: /\.js$/,
exclude: /(test|bower_components|node_modules)/,
loader: 'istanbul-instrumenter',
exclude: /(test|node_modules)/,
loader: 'istanbul-instrumenter-loader',
query: {
esModules: true
}
},
{
test: /\.js$/,
include: /src/,
exclude: /(bower_components|node_modules)/,
loader: 'eslint-loader'
}
],
loaders: [
{
test: /\.js$/,
exclude: /(node_modules|bower_components)/,
loader: 'babel'
},
{
exclude: /node_modules/,
loader: 'babel-loader?cacheDirectory',
options: {
babelrc: true
}
}, {
test: /\.styl$/,
loader: 'css-loader!stylus-loader?paths=src/css/'
use: ['css-loader', 'stylus-loader']
}
]
}
Expand Down
Loading

0 comments on commit ea5a378

Please sign in to comment.