feat: Update fabric.js version to v2.7.0 #201
Conversation
| const $btnLoadMaskImage = $('#input-mask-image-file'); | ||
| const $btnApplyMask = $('#btn-apply-mask'); | ||
| const $btnClose = $('.close'); | ||
| var $btns = $('.menu-item'); |
There was a problem hiding this comment.
μ λΆ λ€ varλ‘ λ°κΎΌ νΉλ³ν μ΄μ κ° μλμ, exampleμ λΈλΌμ°μ μ§μμ μνκ±°μ£ ?
There was a problem hiding this comment.
λ€ λ§μμ. IEκ°μ λΈλΌμ°μ μμλ λμνμ§ μμκ±° κ°μμ μμ νμ΅λλ€.
|
|
||
| return rotationComp.setAngle(angle); | ||
| if (type === 'setAngle') { | ||
| return rotationComp[type](this.undoData.angle); |
There was a problem hiding this comment.
μλμ²λΌ νμ€λ‘ ννν΄λ μ’μκ² κ°κ³
rotationComp[(type==='setAngle') ? type : rotate](angle);
undoData.angleκ³Ό args μ μλ κ°μ΄ λ€λ₯Έ κ°μΈκ°μ? undoDataμ μλ μλ‘μ΄ κ°μ΄ μ€λκΉ μ‘°κΈ νΌλμ€λ½λ€μ
λμ€μλ setAngleκ³Ό rotateμ 컀맨λ μ체λ₯Ό λΆλ¦¬νλκ²λ κ³ λ €ν΄λ΄μΌ λ κ² κ°μμ
There was a problem hiding this comment.
μκ³ νμ ¨μ΅λλ€. 리뷰 μλ£νμ΅λλ€.
There was a problem hiding this comment.
μ¬μ€μ this.undoData.angleμ rotateνλ κ°λμ setAngleνλ κ°λκ° νΌμ¬λμ΄μ rotateλ μ€νλ κ°λλ₯Ό κ·Έλλ‘ λ°μ ν΄μ μ μ©νλ©΄ λκ³ , setAngleμμλ§ this.undoData.angleμ΄ μ΄μ μν μν μ νλλ‘ κ°λ°νμ΅λλ€.
μ΄μ 보λ λ§μνμ κ² μ²λΌ λ 컀맨λλ₯Ό λΆλ¦¬νλκ² μ’μκ±° κ°λ€κ³ μκ°λλ€μ. μ£ΌμμΌλ‘ λ¬μλκ² μ΅λλ€. κ°μ¬ν©λλ€.
) * interim * interim * interim: named import * fix: Deleting i-text by backspace or delete key pressed when text editing * fix: Resolve rotation breaking change * interim: Normalize filters except RemoveWhite, ColorFilter, GradientTransparency * interim: cropzone * fix: Set color method of Icon * fix: Mask filter * fix: Change group type verification to 'activeSelection' * fix: Cropzone rendering * fix: Disable objectCaching * fix: Resolve rotation range bar malfunction * fix: Resolve cropzone scaling issue * fix: Modify getCropzoneRect() cropzone api * interim: Remaining range bar rotation undo/redo feature * fix: Resolve T/C Errors * fix: fabric.js external aid * feat: Synchronize range bar and value with current image rotation info * fix: fabric.js external aid * fix: Return _rotate() promise * fix: Check text double clicked for edit text * fix: Resolve Basic example's bugs * fix: Resolve T/C error * chore: Modify JSDoc * fix: Return what it got * chore: Update JSDoc * chore: Revert codes * fix: Remove Gradient Transparency * chore: Change karma environment * fix: Rotate button error
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
ref: #129
Thank you for your contribution to TOAST UI product. π π β¨