Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Update Fabric.js version #129

Closed
junghwan-park opened this issue Jan 18, 2019 · 2 comments
Closed

update: Update Fabric.js version #129

junghwan-park opened this issue Jan 18, 2019 · 2 comments
Assignees
Labels
Enhancement Enhance performance or improve usability of original features.
Milestone

Comments

@junghwan-park
Copy link
Member

junghwan-park commented Jan 18, 2019

AS-IS

  • Currently TOAST UI Image-Editor using [email protected]
  • [email protected] doesn't support ES module import
  • TOAST UI Image-Editor installs Fabric.js via npm script postinstall and imports fabric import fabric from 'fabric/dist/fabric.require';

TO-BE

  • Update Fabric.js latest version.
  • Change Fabric.js import method to ES module (Named) import

Change

  • GradientTransparency filter removed by fabric.js
@junghwan-park junghwan-park added the Enhancement Enhance performance or improve usability of original features. label Jan 18, 2019
@junghwan-park junghwan-park self-assigned this Jan 18, 2019
@junghwan-park junghwan-park added this to To do in Enhancements Jan 30, 2019
@junghwan-park junghwan-park moved this from To do to In progress in Enhancements Mar 8, 2019
@junghwan-park
Copy link
Member Author

  • fabric.js-v3.2.0 적용 테스트중
    • 사용에는 이상 없음.
    • 하지만, commonjs 패턴으로 모듈이 정의되면 amd 모듈을 정의할 수 있더라도 정의하지 않도록 번들링 코드가 수정되어서 karma로 수행하는 테스트에서 fabric을 정상적으로 가져올 수 없음.
    • 해당 이슈를 webpack 설정이나 karma 설정으로 해결 가능한지 R&D가 더 필요함.

@junghwan-park
Copy link
Member Author

  • karma내부 webpack 설정도 기존 webpack.config.json과 동일하게 fabric.js를 externals 에 추가하고 files에 fabric.js를 추가해서 브라우저에서 로드하도록 수정하여 해결함.
  • fabric 수정은 필요하지 않았음.

@junghwan-park junghwan-park added this to the v3.7.0 milestone Aug 1, 2019
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
…ion (fix nhn#129, nhn#134, nhn#219) (nhn#234)

* fix: Resolve jQuery vulnerability

* fix: Change fabric import method named to default & correct webpack external config (fix nhn#129, nhn#219)

* fix: Add fabric.js to external library into karma webpack config (fix nhn#134)

* fix: Add half stroke width to center added icon's left, top
@jinwoo-kim-nhn jinwoo-kim-nhn moved this from In progress to Done in Enhancements Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
Enhancements
  
Done
Development

No branches or pull requests

1 participant