Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add IGraphicObjectProps property type 'undefined' (fix: #190) #198

Merged
merged 2 commits into from
May 3, 2019
Merged

fix: Add IGraphicObjectProps property type 'undefined' (fix: #190) #198

merged 2 commits into from
May 3, 2019

Conversation

junghwan-park
Copy link
Member

@junghwan-park junghwan-park commented May 2, 2019 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • [] Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@junghwan-park junghwan-park merged commit 4c5fd58 into master May 3, 2019
@junghwan-park junghwan-park deleted the fix/types branch May 3, 2019 09:22
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@junghwan-park @HerlinMatos
fix: Add IGraphicObjectProps property type 'undefined' (fix: nhn#190) (…
f826f6a 
…nhn#198)

* fix: Add IGraphicObjectProps property type 'undefined' (fix: nhn#190)

* fix: Add "ImageEditor.ui.resizeEditor()" type definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@junghwan-park