fix: Add "ImageEditor.ui.resizeEditor()" type definition

nhn · May 2, 2019 · 610c238 · 610c238
1 parent 6cddc22
commit 610c238
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -228,8 +228,30 @@ declare namespace tuiImageEditor {
  selectionStyle?: ISelectionStyleConfig;
  }
 
+ interface IUIDimension {
+ height?: string;
+ width?: string;
+ }
+
+ interface IImageDimension {
+ oldHeight?: number;
+ oldWidth?: number;
+ newHeight?: number;
+ newWidth?: number;
+ }
+
+ interface IEditorSize {
+ uiSize?: IUIDimension,
+ imageSize?: IImageDimension
+ }
+
+ interface UI {
+ resizeEditor(dimension: IEditorSize): Promise<void>;
+ }
+
  class ImageEditor {
  constructor(wrapper: string | Element, options: IOptions);
+ public ui: UI;
 
  public addIcon(type: string, options?: IIconOptions): Promise<IObjectProps>;
  public addImageObject(imgUrl: string): Promise<void>;

diff --git a/src/js/ui.js b/src/js/ui.js
@@ -41,7 +41,7 @@ const BI_EXPRESSION_MINSIZE_WHEN_TOP_POSITION = '1300';
  * @param {Object} [options.uiSize] - ui size of editor
  * @param {string} options.uiSize.width - width of ui
  * @param {string} options.uiSize.height - height of ui
- * @param {Objecdt} actions - ui action instance
+ * @param {Object} actions - ui action instance
  */
 class Ui {
  constructor(element, options, actions) {
@@ -103,8 +103,8 @@ class Ui {
  * Change editor size
  * @param {Object} resizeInfo - ui & image size info
  * @param {Object} resizeInfo.uiSize - image size dimension
- * @param {Number} resizeInfo.uiSize.width - ui width
- * @param {Number} resizeInfo.uiSize.height - ui height
+ * @param {string} resizeInfo.uiSize.width - ui width
+ * @param {string} resizeInfo.uiSize.height - ui height
  * @param {Object} resizeInfo.imageSize - image size dimension
  * @param {Number} resizeInfo.imageSize.oldWidth - old width
  * @param {Number} resizeInfo.imageSize.oldHeight - old height
@@ -247,8 +247,8 @@ class Ui {
  /**
  * Set ui container size
  * @param {Object} uiSize - ui dimension
- * @param {number} width - width
- * @param {number} height - height
+ * @param {string} uiSize.width - width
+ * @param {string} uiSize.height - height
  * @private
  */
  _setUiSize(uiSize = this.options.uiSize) {

diff --git a/test/types/type-tests.ts b/test/types/type-tests.ts
@@ -295,3 +295,5 @@ imageEditor.on('addText', pos => {
  console.log(`text position on canvas : ${pos.originPosition}`);
  console.log(`text position on browser : ${pos.clientPosition}`);
 });
+imageEditor.ui.resizeEditor({uiSize: {width: '600px', height: '1200px'}});
+imageEditor.ui.resizeEditor({imageSize: {newWidth: 300, newHeight: 140}});