fix: Add shape on mouseClick without mouseMove (fix #144) #146
Conversation
junghwan-park
changed the title
| @@ -364,14 +370,24 @@ class Shape extends Component { | |||
| */ | |||
| _onFabricMouseUp() { | |||
| const canvas = this.getCanvas(); | |||
| const startPointX = this._startPoint.x; | |||
There was a problem hiding this comment.
μ΄ λΆλΆμ λμ€νΈλμ²λ§+alias μμ°λκ² ν¨μ¬ λ κΉλνλ€μ. κ΅Ώ
There was a problem hiding this comment.
λ€, κ°λ¨νκ² νννλκ² μ’λλΌκ³ μ. :)
λ€λ₯Έ μ½λμμλ μ ννλ‘ μ¬μ©νκ³ μμ΄μ κ·Έλλ‘ μ μ©νμ΅λλ€.
| @@ -27,7 +27,6 @@ class Component { | |||
|
|
|||
| /** | |||
| * Fire Graphics event | |||
| * @param {Array} args - arguments | |||
There was a problem hiding this comment.
jsdoc, μ€νλ λ νλΌλ―Έν° ννν μ μλ λ°©λ²μ΄ μλμ? νΉμ?
There was a problem hiding this comment.
JSDoc - @param μ Allows a parameter to be repeated μΉμ
μ²λΌ λ°λ³΅λλ λμΌν νμ
μ μ μν λ rest parameterλ₯Ό μ¬μ©ν μ μμ΅λλ€.
μ΄ λ©μλλ λμΌν νμ
μ λ°λ³΅μ λνλ΄λλ° μ¬μ©νκ³ μμ§ μμμ μ κ±°νμ΅λλ€.
|
리뷰 μλ£νμ΅λλ€. μκ³ νμ ¨μ΄μ. |
|
|
||
| const objectProperties = this.graphics.createObjectProperties(shapeObj); | ||
|
|
||
| resolve(objectProperties); |
There was a problem hiding this comment.
objectProperties λ‘ μ μ ν resolve ν΄μ£Όλ μ΄μ κ° μμκΉμ?
μ μ£Όκ΄μ μΈ μκ°μλ νμ€μ΄ λ κΉλν΄ λ³΄μ΄λ€μ
There was a problem hiding this comment.
λ³μλ‘ λ°λ‘ μ μνλκ² resolve()λ₯Ό μλ―Έμ μΌλ‘ λΆλ¦¬ν΄μ£Όλκ² κ°μμ λ³κ²½νμ΅λλ€.
|
μκ³ νμ ¨μ΅λλ€. |
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Add shape on mouseClick without mouseMove.
Thank you for your contribution to TOAST UI product. π π β¨