Behaviour when clicking canvas without moving mouse in shapes mode

[jonaspu]

Version

3.4.0

Development Environment

Tested on Firefox, Google Chrome

Current Behavior

1. Choose any shape (Rectangle, Circle, Triangle).
2. Click on canvas without moving mouse, release mouse button.
3. The shape's second corner now follows the cursor without the mouse button being pressed.
4. Clicking on the canvas again, the shape is added but there is also a new shape with the first corner already set.

Image with the clicks marked:

Expected Behavior

Click and release at the same spot should not add anything.

Possible fix

In src/js/component/shape.js replace

_onFabricMouseUp() {
    const canvas = this.getCanvas();
    const shape = this._shapeObj;

    if (shape) {
        resizeHelper.adjustOriginToCenter(shape);
    }

    this.fire(eventNames.ADD_OBJECT_AFTER, this.graphics.createObjectProperties(shape));

    canvas.off({
        'mouse:move': this._handlers.mousemove,
        'mouse:up': this._handlers.mouseup
    });
}

with

_onFabricMouseUp() {
    const canvas = this.getCanvas();
    const shape = this._shapeObj;

    if (shape) {
        resizeHelper.adjustOriginToCenter(shape);
        this.fire(eventNames.ADD_OBJECT_AFTER, this.graphics.createObjectProperties(shape));
    }

    canvas.off({
        'mouse:move': this._handlers.mousemove,
        'mouse:up': this._handlers.mouseup
    });
}

This way if the mouse isn't moved nothing happens.