Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change loadButton tag to div (fix #137) #145

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

junghwan-park
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Change UI Load button Tag 'button' to 'div'.
Because of input tag in button tag is invalid html, the button in Firefox does not working as expected.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@junghwan-park junghwan-park added this to the v3.5.0 milestone Feb 13, 2019
@junghwan-park junghwan-park self-assigned this Feb 13, 2019
@junghwan-park junghwan-park changed the title fix: Change loadButton tag to div fix #137 fix: Change loadButton tag to div (fix #137) Feb 13, 2019
@arifhussain353
Copy link

arifhussain353 commented Feb 13, 2019

@junghwan-park Thanks for this fix. I think it should also be changed in controls.js tui-image-editor-controls-buttons for footer view buttons? https://github.com/nhnent/tui.image-editor/blob/1562a4434f50241c84928ec539e023eee23ecb2d/src/js/ui/template/controls.js#L51

@dongsik-yoo
Copy link
Contributor

수고하셨습니다. 리뷰 완료했습니다.

Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@junghwan-park junghwan-park merged commit 4361dff into master Feb 14, 2019
@junghwan-park junghwan-park deleted the fix/load-button-to-div branch February 14, 2019 03:59
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
* fix: Change loadButton tag to div fixes nhn#137

* fix: Change loadButton tag to div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants