Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Button in Image editor UI does not work/function in Firefox browser #137

Closed
Sai-Teja-Payyavula opened this issue Jan 30, 2019 · 3 comments
Closed

Load Button in Image editor UI does not work/function in Firefox browser #137

Sai-Teja-Payyavula opened this issue Jan 30, 2019 · 3 comments
Assignees
@junghwan-park
Labels
Bug
Milestone
v3.5.0

Comments

@Sai-Teja-Payyavula
Copy link

Sai-Teja-Payyavula commented Jan 30, 2019 •
edited
Loading

Version

v3.3.0

Development Environment

Mozilla Firefox, Window 7 OS

Current Behavior

Doesnt throw an error or bug when its clicked in Mozilla browser.
Usually load button works in other browsers.
Even in the demo page the load button isnt working.
http:https://nhnent.github.io/tui.image-editor/latest/tutorial-example01-includeUi.html

Expected Behavior

Working load funcion

Thank You.
@Sai-Teja-Payyavula Sai-Teja-Payyavula changed the title Load Button in UI Api Image editor does not work/function in Firefox browser Load Button in Image editor UI does not work/function in Firefox browser Jan 30, 2019
@dannymick
Copy link

I'm getting a TypeError: e is null error around tui-image-editor.min.js:8:25404 whenever I click the Load button in FF65.

@arifhussain353
Copy link

arifhussain353 commented Feb 11, 2019 •
edited
Loading

I can confirm this issue. In Firefox v65.0 (64-bit) load button not working. The issue occurs because the input file is used inside button tag which is not a valid HTML. Changing into div tag fixed issue for me.

@junghwan-park
Copy link
Member

@arifhussain353
Thanks. I'll fix this right away.

junghwan-park added a commit that referenced this issue Feb 13, 2019
@junghwan-park
fix: Change loadButton tag to div fixes #137
1562a44
@junghwan-park junghwan-park self-assigned this Feb 13, 2019
@junghwan-park junghwan-park added this to the v3.5.0 milestone Feb 13, 2019
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@junghwan-park @HerlinMatos
fix: Change loadButton tag to div (fix nhn#137) (nhn#145)
7534385 
* fix: Change loadButton tag to div fixes nhn#137

* fix: Change loadButton tag to div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junghwan-park junghwan-park

Labels
Bug
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
4 participants
@dannymick @junghwan-park @arifhussain353 @Sai-Teja-Payyavula