Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure reject on loadImage failed (fix #116) #128

Merged
merged 3 commits into from
Jan 18, 2019
Merged

fix: Ensure reject on loadImage failed (fix #116) #128

merged 3 commits into from
Jan 18, 2019

Conversation

junghwan-park
Copy link
Member

@junghwan-park junghwan-park commented Jan 18, 2019 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Issue #116

Bug fix

  • Check oImage existence before using method

Chore

  • Add missing rejectMessages

Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

@junghwan-park junghwan-park self-assigned this Jan 18, 2019
jinwoo-kim-nhn
jinwoo-kim-nhn approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€. 리뷰 μ™„λ£Œν–ˆμŠ΅λ‹ˆλ‹€.

dongsik-yoo
dongsik-yoo reviewed Jan 18, 2019
View reviewed changes
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[01/18] μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.

src/js/consts.js
redo: 'The promise of redo command is reject.',
rotation: 'The current angle is same the old angle.',
undo: 'The promise of undo command is reject.',
unsupportedOperation: 'Unsupported operation.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μΆ”κ°€λœ λ©”μ‹œμ§€λŠ” μ‚¬μš©λ˜λŠ” 곳이 μžˆλŠ”κ±°μ£ ? λ³€κ²½ μ‚¬ν•­μ—μ„œλŠ” μ•ˆ λ³΄μ—¬μ„œμš”.

Copy link
Member Author

@junghwan-park junghwan-park Jan 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„€, rejectMessages.loadingImageFailed κ°€ μ—†μ–΄μ„œ reject λ©”μ‹œμ§€κ°€ undefied둜 λ‚˜μ˜€κΈΈλž˜ λ©”μ‹œμ§€λ₯Ό μΆ”κ°€ν•˜λ©΄μ„œ rejectMessagesμ—μ„œ μ°Έμ‘°ν•˜λŠ” λΆ€λΆ„λ§Œ 있고 μ •μ˜κ°€ μ•ˆλœ λ©”μ‹œμ§€λ“€λ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

@junghwan-park junghwan-park merged commit b70dadd into master Jan 18, 2019
@junghwan-park junghwan-park deleted the fix/loadImage-rejection branch January 18, 2019 06:29
@junghwan-park junghwan-park added this to the v3.5.0 milestone Feb 13, 2019
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@junghwan-park @HerlinMatos
fix: Ensure reject on loadImage failed (fix nhn#116) (nhn#128)
b2942fc 
* fix: Check oImage existence before use fixes nhn#116

* fix: Add rejectMessage for 'loadingImageFailed'

* chore: Add missing message and order messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsik-yoo dongsik-yoo dongsik-yoo left review comments

@jinwoo-kim-nhn jinwoo-kim-nhn jinwoo-kim-nhn approved these changes

Assignees

@junghwan-park junghwan-park

Labels
Bug
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@junghwan-park @dongsik-yoo @jinwoo-kim-nhn