loadImageFromFile and loadImageFromURL silently fail for unrecognized image formats

[dxoxp]

Version

tui-image-editor.js 3.3.0

Development Environment

Windows 7
Chrome 71
Firefox 64

Current Behavior

Attempting to load unrecognized image formats cause an exception in the image editor that cannot be caught.

Normally one would attempt to use loadImageFromFile or loadImageFromURL in a promise construct like:

imageEditor.loadImageFromFile(x)
	.then( function() {
		// Do "success" processing
	})
	.catch( function() {
		// Do "failure" processing
	} );

However, if the image cannot be successfully loaded, the image editor throws and exception that bypasses the ".catch()" function.

Also, wrapping the loadImageFromFile in a native try/catch handler does not help either.

This behavior makes it difficult to know if the editor actually loaded the image successfully.

Steps to Reproduce:

1. Open the URL http:https://ui.toast.com/tui-image-editor/ in a browser.
2. Click the "Load" button and choose a text file. (This also happens for image file formats that the particular browser does not understand.)
3. Notice that the Promise's ".catch()" function is not executed.
4. Notice that the editor produces an exception in the browser console.

Uncaught TypeError: Cannot read property 'getElement' of null
    at tui-image-editor.js:15184
    at klass.<anonymous> (fabric.js:6411)
    at HTMLImageElement.img.onerror (fabric.js:642)

Suggestion:

On line 15184 of dist/tui-image-editor.js, the following code is found:

	if (oImage.getElement()) {
		resolve(oImage);
	} else {
		reject(rejectMessages.loadingImageFailed);
	}

Consider enhancing the test to

	if (oImage && oImage.getElement()) {

This allows the promise to be rejected and handled by the client code.

Expected Behavior

The .catch function for the promises returned by loadImageFromURL and loadImageFromFile should be called if the image cannot be loaded.

[T-vK]

I just ran into the same issue. I'd really like to see this getting fixed.

[junghwan-park]

@dxoxp @T-vK
I got this. Thanks! 👍