Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support typescript #108

Merged
merged 8 commits into from
Jan 9, 2019
Merged

feat: support typescript #108

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b523df
feat: support typescript
jungeun-cho Dec 18, 2018
616248d
fix: incorrect jsdoc
jinwoo-kim-nhn Dec 24, 2018
9fee613
Merge branch 'master' into feat/typescript-support
jungeun-cho Dec 26, 2018
6310067
Merge remote-tracking branch 'origin/feat/typescript-support' into fe…
jungeun-cho Dec 26, 2018
13bc291
chore: apply feedback
jungeun-cho Dec 26, 2018
3a2b4e4
chore: fix any type
jungeun-cho Jan 2, 2019
c417bca
chore: add script for tslint
jungeun-cho Jan 2, 2019
08edee7
chore: remove unnecessary comment
jungeun-cho Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: remove unnecessary comment
  • Loading branch information
@jungeun-cho
jungeun-cho committed Jan 2, 2019
commit 08edee78a59f0c20b6bef037ca9f91678f712180
3 changes: 1 addition & 2 deletions test/types/type-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ imageEditor.addShape('circle', {
console.log(objectProps.id);
});

// doc에 정의된 옵션과 예제에서 사용방식이 틀림
imageEditor.addText('initText', {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예제가 맞습니다.

styles: {
fill: '#000',
Expand Down Expand Up @@ -243,7 +242,7 @@ imageEditor.setBrush({
});
imageEditor.setBrush({
width: 20,
color: 'FFFFFF' // #(샵) 안붙여도될까요?
color: '#FFFFFF'
});
imageEditor.setCropzoneRect(1/1);
imageEditor.setDrawingShape('rect', {
Expand Down