feat: support typescript #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jungeun-cho
commented
Dec 18, 2018
jungeun-cho
commented
- add declaration file for Typescript
|
리뷰 완료 했습니다. 오래걸려서 죄송해요 수고하셨습니다. |
|
@jinwoo-kim-nhn |
jungeun-cho
commented
Jan 2, 2019
test/types/type-tests.ts
Outdated
| }); | ||
| imageEditor.setBrush({ | ||
| width: 20, | ||
| color: 'FFFFFF' // #(샵) 안붙여도될까요? |
| }); | ||
|
|
||
| // doc에 정의된 옵션과 예제에서 사용방식이 틀림 | ||
| imageEditor.addText('initText', { |
|
Looking forward to having this available! |
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* feat: support typescript * fix: incorrect jsdoc * chore: apply feedback * chore: fix any type * chore: add script for tslint * chore: remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.