Issue #104 - "mkdir -p" fail on Windows OS was fixed #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@jinwoo-kim-nhn, maybe should I change npm version of tui.image-editor, when I do PR? |
anton-marchenko
force-pushed
the
issue/104
branch
from
47359fa
to
8625295
Compare
dongsik-yoo
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
Changes are simple and nothing to comment. Thank you.
@jinwoo-kim-nhn Request final confirm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #104 - "mkdir -p" fail on Windows OS was fixed
Description
When I do npm run bundle:svg I see error, because flag "-p" (
mkdir -p dist/svg) unsupported on Windows systems.I fixed it whith Node.js mkdirp library.