Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm run bundle:svg does not work on Windows 10 OS #104

Closed
marchenko-am opened this issue Dec 17, 2018 · 1 comment
Closed

npm run bundle:svg does not work on Windows 10 OS #104

marchenko-am opened this issue Dec 17, 2018 · 1 comment

Comments

@marchenko-am
Copy link

Version

tui-image-editor 3.3.0

Development Environment

Windows 10 x64

Description

It is because you make command with Linux flag "-p": mkdir -p dist/svg.
I will fix it and make pull request.
marchenko-am pushed a commit to marchenko-am/tui.image-editor that referenced this issue Dec 17, 2018
@anton-marchenko
nhn#104 - "mkdir -p" fail on Windows OS was fixed
c34a742
marchenko-am pushed a commit to marchenko-am/tui.image-editor that referenced this issue Dec 17, 2018
@anton-marchenko
nhn#104 - refactoring for svgDir
47359fa
@marchenko-am marchenko-am mentioned this issue Dec 17, 2018
Closed
@marchenko-am
Copy link
Author

marchenko-am commented Dec 17, 2018 •
edited

When I do npm run bundle:svg I see error, because flag "-p" (mkdir -p dist/svg) unsupported on Windows systems.

I fixed it whith Node.js mkdirp library.

Please, look at my Pull Request

@anton-marchenko anton-marchenko mentioned this issue Dec 17, 2018
Merged
anton-marchenko added a commit to anton-marchenko/am.image-editor that referenced this issue Dec 17, 2018
@anton-marchenko
refactor: nhn#104 - refactoring for svgDir
8625295
dongsik-yoo pushed a commit that referenced this issue Dec 21, 2018
Merge pull request #106 from anton-marchenko/issue/104
5e70e1d 
Issue #104 - "mkdir -p" fail on Windows OS was fixed
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@anton-marchenko @HerlinMatos
fix: nhn#104 - "mkdir -p" fail on Windows OS was fixed
4e6445a
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@anton-marchenko @HerlinMatos
refactor: nhn#104 - refactoring for svgDir
b08ba0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marchenko-am