Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): upgrade to v2 of tslib #16

Closed
wants to merge 1 commit into from
Closed

chore(deps-dev): upgrade to v2 of tslib #16

wants to merge 1 commit into from

Conversation

celluj34
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] Other... Please describe: depedency update

What is the current behavior?

Issue Number: #11 #15

What is the new behavior?

Use tslib v2+

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@NetanelBasal
Copy link
Member

Thanks, but I meant to upgrade the entire lib to v12, and create a new major version.

@celluj34
Copy link
Author

The reason I only did this much was because (somehow) in the published version of the library, tslib is the only dependency. So there isn't a need to upgrade any others.

I can upgrade the other packages too though, if you feel like it's necessary.

@NetanelBasal
Copy link
Member

Yes, because upgrading to v2 is already a breaking change.

@shamoon
Copy link

shamoon commented Feb 28, 2022

@celluj34 / @NetanelBasal any updates on this?

@NetanelBasal
Copy link
Member

It should be part of #18

@shaharkazaz
Copy link
Contributor

Fixed by fa1e5f9, released in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants