Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tslib@2 #15

Closed
celluj34 opened this issue Oct 18, 2021 · 2 comments
Closed

Upgrade tslib@2 #15

celluj34 opened this issue Oct 18, 2021 · 2 comments

Comments

@celluj34
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

When using the library with angular 12, I get an error during npm i that there is a discrepancy between conflicting versions of tslib. This library requires tslib@"^1.10.0" whereas angular requires tslib@"^2.3.0".

Expected behavior

Library should be compatible and install with recent versions of angular.

Minimal reproduction of the problem with instructions

npm i @angular/common @angular/core tslib @ngneat/dirty-check-forms

What is the motivation / use case for changing the behavior?

Motivation is self-explanatory; I want to use this library with angular 12.

Environment


Angular version: X.Y.Z


Browser:
- [X] Chrome (desktop) version XX
- [X] Chrome (Android) version XX
- [X] Chrome (iOS) version XX
- [X] Firefox version XX
- [X] Safari (desktop) version XX
- [X] Safari (iOS) version XX
- [X] IE version XX
- [X] Edge version XX
 
For Tooling issues:
- Node version: v14.18.1
- Platform: Windows 10 x64

Others:
n/a
@NetanelBasal
Copy link
Member

You're welcome to create a PR that upgrades to v12.

@shaharkazaz
Copy link
Contributor

Fixed by fa1e5f9, released in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants