Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORES: Update STRINGTIE module to use path rather than map #4879

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

adamrtalbot
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@maxulysse maxulysse added this pull request to the merge queue Feb 12, 2024
Merged via the queue into nf-core:master with commit 5756b12 Feb 12, 2024
15 checks passed
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
…4879)

* CHORES: Update STRINGTIE module to use path rather than map

* update stringtie tests

* Update modules/nf-core/stringtie/merge/tests/main.nf.test

---------

Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
…4879)

* CHORES: Update STRINGTIE module to use path rather than map

* update stringtie tests

* Update modules/nf-core/stringtie/merge/tests/main.nf.test

---------

Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants