Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename etc-no-blacklisted to etc-hide-blacklisted #5595

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Jan 16, 2023

To avoid boolean confusion (no-foo no / no-foo yes) in
firejail.config:

etc-no-blacklisted no
etc-no-blacklisted yes

Commands used to search and replace:

git grep -Ilz -i 'etc.no.blacklisted' -- etc src |
  xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
    -e 's/etc-no-blacklisted/etc-hide-blacklisted/' \
    -e 's/ETC_NO_BLACKLISTED/ETC_HIDE_BLACKLISTED/' \
    '{}')\" >'{}'"

Added on commit ded5020 ("opt-in: skip blacklisted files in
private-etc - #5010, #5230", 2023-01-15) / PR #5591.

To avoid boolean confusion (`no-foo no` / `no-foo yes`) in
firejail.config:

    etc-no-blacklisted no
    etc-no-blacklisted yes

Commands used to search and replace:

    git grep -Ilz -i 'etc.no.blacklisted' -- etc src |
      xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
        -e 's/etc-no-blacklisted/etc-hide-blacklisted/' \
        -e 's/ETC_NO_BLACKLISTED/ETC_HIDE_BLACKLISTED/' \
        '{}')\" >'{}'"

Added on commit ded5020 ("opt-in: skip blacklisted files in
private-etc - netblue30#5010, netblue30#5230", 2023-01-15) / PR netblue30#5591.
To make it clearer.

Added on commit ded5020 ("opt-in: skip blacklisted files in
private-etc - netblue30#5010, netblue30#5230", 2023-01-15) / PR netblue30#5591.
Let users know that enabling this may break /etc/resolv.conf.

Added on commit ded5020 ("opt-in: skip blacklisted files in
private-etc - netblue30#5010, netblue30#5230", 2023-01-15) / PR netblue30#5591.
@kmk3 kmk3 added this to In progress in Release 0.9.72 via automation Jan 16, 2023
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Potentially less confusing calling the pref this way IMO.

@netblue30 netblue30 merged commit bced772 into netblue30:master Jan 16, 2023
@netblue30
Copy link
Owner

Merged, thanks!

@kmk3 kmk3 deleted the rename-etc-no-blacklisted branch January 16, 2023 13:54
kmk3 added a commit that referenced this pull request Jan 16, 2023
@kmk3 kmk3 moved this from In progress to Done (on RELNOTES) in Release 0.9.72 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.9.72
  
Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants