modif: stop hiding blacklisted files in /etc by default and add a new etc-no-blacklisted option #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitsohu
force-pushed
the
private-etc-no-blacklisted
branch
from
76e2829
to
2204185
Compare
smitsohu
changed the title
glitsj16
approved these changes
Jan 15, 2023
|
Thanks @glitsj16 Unfortunately I think I will need to update the pull request one more time, also to fix the failing test, sorry for that! Converting to draft ... |
smitsohu
force-pushed
the
private-etc-no-blacklisted
branch
from
2204185
to
ceb877b
Compare
smitsohu
force-pushed
the
private-etc-no-blacklisted
branch
from
ceb877b
to
f754fd9
Compare
|
The fix is straightforward - @smitsohu, let's do like this: I'll grab it as is and fix whatever is to fix in "make test", and you check in directly whatever else you need to modify. Then, I'll release it, quite simple! |
|
@netblue30 I think it should be ok the way it is now. Maybe I rearrange it at a later timepoint, after the release is out. |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jan 16, 2023
To avoid boolean confusion (`no-foo no` / `no-foo yes`) in
firejail.config:
etc-no-blacklisted no
etc-no-blacklisted yes
Commands used to search and replace:
git grep -Ilz -i 'etc.no.blacklisted' -- etc src |
xargs -0 -I '{}' sh -c "printf '%s\n' \"\$(sed \
-e 's/etc-no-blacklisted/etc-hide-blacklisted/' \
-e 's/ETC_NO_BLACKLISTED/ETC_HIDE_BLACKLISTED/' \
'{}')\" >'{}'"
Added on commit ded5020 ("opt-in: skip blacklisted files in
private-etc - netblue30#5010, netblue30#5230", 2023-01-15) / PR netblue30#5591.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jan 16, 2023
To make it clearer. Added on commit ded5020 ("opt-in: skip blacklisted files in private-etc - netblue30#5010, netblue30#5230", 2023-01-15) / PR netblue30#5591.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jan 16, 2023
Let users know that enabling this may break /etc/resolv.conf. Added on commit ded5020 ("opt-in: skip blacklisted files in private-etc - netblue30#5010, netblue30#5230", 2023-01-15) / PR netblue30#5591.
kmk3
changed the title
|
Related commit: ba9c969 ("Removing blacklisted files from top level /etc For future reference, the default behavior on 0.9.68 and 0.9.70 (due to the |
kmk3
added a commit
that referenced
this pull request
Jan 16, 2023
kmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5010
Closes #5230