build: Remove deprecated syntax and modernize shell test scripts #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test directly for presence of command instead of indirectly testing the return code. Additionally: * uses a shell builtin `command -v` instead of external `which` * `command -v` is the standardized version of `which`
rusty-snake
approved these changes
Sep 14, 2022
| echo "${arr[16]}" | ||
| echo "${arr[17]}" | ||
| echo "${arr[18]}" | ||
| echo "${arr[19]}" |
There was a problem hiding this comment.
We could use a loop here.
There was a problem hiding this comment.
yes, it can be replaced with
printf '%s\n' "Legend:" "${arr[@]}"but I didn't want to make more changes than necessary
|
merged, thanks! |
kmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I performed the minimum number of changes that still preserves the same old behavior, but fixes some errors and other minor issues.