Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: only install ids.config when --enable-ids is set #5357

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Sep 3, 2022

This PR ensures ids.config only gets installed when --enable-ids is set during configure. Fixes #5356.

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to make it clearer (it sounds like ids.config currently isn't being
installed at all):

build: install ids.config when --enable-ids is set

->

build: install ids.config only when --enable-ids is set


Fix for #5356.

Please add such details to the commit message body, as it makes it easier to
track all commits related to a specific issue.

Other than that, LGTM.

@glitsj16 glitsj16 changed the title build: install ids.config when --enable-ids is set build: install ids.config only when --enable-ids is set Sep 4, 2022
@glitsj16
Copy link
Collaborator Author

glitsj16 commented Sep 4, 2022

@kmk3 Thanks for your review and suggestion. Updated accordingly.

@kmk3
Copy link
Collaborator

kmk3 commented Sep 4, 2022

@glitsj16 commented on Sep 4:

@kmk3 Thanks for your review and suggestion.

No problem.

Updated accordingly.

Sorry, I meant in the commit message itself.

Not sure about the web UI, but the commit message can be changed locally with:

git fetch
git checkout ids-fix
git commit --amend
git push --force-with-lease

This PR ensures ids.config only gets installed when --enable-ids is set during configure.
Fixes netblue30#5356.
@glitsj16
Copy link
Collaborator Author

glitsj16 commented Sep 4, 2022

@kmk3 I hope I didn't break anything, thanks for your patience!

@kmk3 kmk3 changed the title build: install ids.config only when --enable-ids is set build: only install ids.config when --enable-ids is set Sep 4, 2022
@kmk3
Copy link
Collaborator

kmk3 commented Sep 4, 2022

(Updated the PR title to match the commit message title)

@glitsj16 commented on Sep 4:

@kmk3 I hope I didn't break anything, thanks for your patience!

LGTM; no worries!

@glitsj16 glitsj16 merged commit 9aef909 into netblue30:master Sep 4, 2022
@glitsj16 glitsj16 deleted the ids-fix branch September 4, 2022 08:22
kmk3 added a commit that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

build: ids.config should only be installed when --enable-ids is set during configure
3 participants