Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node-gyp failing to build canvas #5202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix node-gyp failing to build canvas #5202

wants to merge 1 commit into from

Commits on Jun 14, 2022

  1. Fix node-gyp failing to build canvas 

    So there is a commonly use node (npm) package called "canvas", which uses node-gyp to bind to cairo (2D canvas drawing library). And I assume this is useful outside of this particular case. node-gyp (run by `yarn install` or `npm install`) needs access to `/usr/share/pkgconfig` otherwise it fails to buold the native extensions.

So it's either this proposed change, or it can be move to `yarn.profile` or `npm.profile`. I'm not sure it will work when moved to `node-gyp.profile` as that one is invoked as a subprocess.

It can also, instead of including `build-systems-common.profile` just whitelist `/usr/share/pkgconfig`.
    @skrat
    skrat committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    2ae4064 View commit details
    Browse the repository at this point in the history