Fix node-gyp failing to build canvas #5202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So there is a commonly use node (npm) package called "canvas", which uses node-gyp to bind to cairo (2D canvas drawing library). And I assume this is useful outside of this particular case. node-gyp (run by `yarn install` or `npm install`) needs access to `/usr/share/pkgconfig` otherwise it fails to buold the native extensions. So it's either this proposed change, or it can be move to `yarn.profile` or `npm.profile`. I'm not sure it will work when moved to `node-gyp.profile` as that one is invoked as a subprocess. It can also, instead of including `build-systems-common.profile` just whitelist `/usr/share/pkgconfig`.
rusty-snake
requested changes
Jun 14, 2022
| @@ -67,6 +67,7 @@ include disable-xdg.inc | |||
| whitelist /usr/share/doc/node | |||
| whitelist /usr/share/nvm | |||
| whitelist /usr/share/systemtap/tapset/node.stp | |||
| include build-systems-common.profile | |||
There was a problem hiding this comment.
- This should go to the end of the file, see https://github.com/netblue30/firejail/blob/master/etc/templates/redirect_alias-profile.template.
- All commands set by
build-systems-common.profileshould be removed here. - All commands unintentional introduced by this must be
ignored.
It can also, instead of including
build-systems-common.profilejust whitelist/usr/share/pkgconfig.
Likely easier than the above.
glitsj16
requested changes
Jun 14, 2022
There was a problem hiding this comment.
There's considerable overlap between nodejs-common and build-systems-common. IMO it's asking for trouble by including the latter in the former. I'll do some testing shortly but adding whitelist /usr/share/pkgconfig to nodejs-common.profile is the cleaner option.
Fix node-gyp failing to build canvas
Do you have a reproducer? Or a more detailed log of what is actually failing?
|
Any yarn npm project that has canvas as a dependency. I'm fine with just |
Yes |
If you mean redo the PR to add whitelist /usr/share/pkgconfig to nodejs-common.profile instead of what you have now: yes please do :-) You might need to rebase for the CI check. |
glitsj16
requested changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there is a commonly use node (npm) package called "canvas", which uses node-gyp to bind to cairo (2D canvas drawing library). And I assume this is useful outside of this particular case. node-gyp (run by
yarn installornpm install) needs access to/usr/share/pkgconfigotherwise it fails to buold the native extensions.So it's either this proposed change, or it can be move to
yarn.profileornpm.profile. I'm not sure it will work when moved tonode-gyp.profileas that one is invoked as a subprocess.It can also, instead of including
build-systems-common.profilejust whitelist/usr/share/pkgconfig.