Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /etc/hosts is_link check #4560

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 19, 2021

This patch fixes #2758 (comment) . Especially for NixOS users, the file /etc/hosts is a symlink and firejail fails with exiting after is_link() check.
Removing this check fixes the issue.

@netblue30 netblue30 merged commit a5c7189 into netblue30:master Sep 24, 2021
@netblue30
Copy link
Owner

Thanks!

kmk3 added a commit to kmk3/firejail that referenced this pull request Jan 26, 2022
Note: They are added in the order that the issues were fixed/closed.

Note2: The issues were found through the following url:

https://github.com/netblue30/firejail/issues?q=is%3Aclosed+label%3Abug+-label%3Asecurity+closed%3A%3E2021-06-29+

The date used is the release date of 0.9.66, so in theory the query
should return every bug closed after that.  Security-related issues are
excluded because they will be added separately.

Note3: All issues other than netblue30#4328 were fixed before 0.9.68rc1.

Relates to netblue30#2758 netblue30#4235 netblue30#4328 netblue30#4387 netblue30#4395 netblue30#4460 netblue30#4467 netblue30#4558 netblue30#4560 netblue30#4586.
@kmk3 kmk3 mentioned this pull request Jan 26, 2022
@kmk3 kmk3 added this to Done (on RELNOTES) in Release 0.9.68 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.9.68
  
Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

Firejail does not work with a custom hosts file
2 participants