Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firejail rejects empty arguments #4395

Closed
reinerh opened this issue Jul 11, 2021 · 3 comments
Closed

Firejail rejects empty arguments #4395

reinerh opened this issue Jul 11, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@reinerh
Copy link
Collaborator

reinerh commented Jul 11, 2021

A Ubuntu user reported that firejail rejects arguments to the application if they are empty.
But for some applications empty arguments are actually valid use cases.
Even with the argument separator (--) firejail still rejects it.

Example:

$ echo ''

$ firejail -- echo ''
Error: too short arguments
$

This is the location of the check:

firejail/src/firejail/main.c

Lines 1027 to 1030 in e66ba7c

if (*argv[i] == 0) {
fprintf(stderr, "Error: too short arguments\n");
exit(1);
}

@reinerh reinerh added the bug Something isn't working label Jul 11, 2021
@netblue30
Copy link
Owner

will do, thanks!

@rusty-snake
Copy link
Collaborator

fix bug: firejail rejects empty arguments

So we can close here?

@netblue30
Copy link
Owner

Yes, closing.

@kmk3 kmk3 added this to To Document (RELNOTES/man) in Release 0.9.68 Dec 23, 2021
kmk3 added a commit to kmk3/firejail that referenced this issue Jan 26, 2022
Note: They are added in the order that the issues were fixed/closed.

Note2: The issues were found through the following url:

https://github.com/netblue30/firejail/issues?q=is%3Aclosed+label%3Abug+-label%3Asecurity+closed%3A%3E2021-06-29+

The date used is the release date of 0.9.66, so in theory the query
should return every bug closed after that.  Security-related issues are
excluded because they will be added separately.

Note3: All issues other than netblue30#4328 were fixed before 0.9.68rc1.

Relates to netblue30#2758 netblue30#4235 netblue30#4328 netblue30#4387 netblue30#4395 netblue30#4460 netblue30#4467 netblue30#4558 netblue30#4560 netblue30#4586.
@kmk3 kmk3 moved this from To Document (RELNOTES/man) to Done (on RELNOTES) in Release 0.9.68 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Release 0.9.68
  
Done (on RELNOTES)
Development

No branches or pull requests

3 participants