Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Position tableCreationGrid absolutely #3321

Merged

Conversation

grebaldi
Copy link
Contributor

@grebaldi grebaldi commented Jan 4, 2023

fixes: #3308

The problem described in #3308 (table creation grid does not show up) is probably a regression through #3227 (it's hard to tell precisely though).

I decided to target 7.3 however, because the fix for #3308 fixes some other oddities as well, that must have been around forever:

Before:

Peek.2023-01-04.10-48.-.Table.before.mp4

This is what happens in 7.3-8.2:

  • The removeFormat button jumps to the right when the tableCreationGrid opens
  • When the tableCreationGrid is open and the Block Format select box is open as well, the options of the latter would appear detached from the select box

After:

Peek.2023-01-04.10-54.-.Table.after.mp4

Now everything stays where it belongs.

@grebaldi grebaldi added the 7.3 label Jan 4, 2023
@grebaldi grebaldi linked an issue Jan 4, 2023 that may be closed by this pull request
@grebaldi grebaldi mentioned this pull request Jan 4, 2023
36 tasks
@crydotsnake crydotsnake added the Bug Label to mark the change as bugfix label Jan 14, 2023
Copy link
Member

@crydotsnake crydotsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works as expected

@jonnitto jonnitto merged commit 70d4ef6 into neos:7.3 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Dropdown for creating tables in RTE toolbar does not open
3 participants