-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Responsive grid UI #3227
Conversation
fyi here is the slack thread (with video) https://neos-project.slack.com/archives/C0U0KEGDQ/p1665750470219249 |
Hi ;) i got around trying this out simplescreenrecorder-2022-10-23_20.15.35.mp4if found some issues:
collapsing the sidebars, full-screen and secondary inspector is working fine (well without animation for now ...) ;) simplescreenrecorder-2022-10-23_20.18.28.mp4 |
This Chrome 107 news could help us with getting in animations again https://web.dev/css-animated-grid-layouts/ |
cc078c9
to
df7be4f
Compare
@mhsdesign thx for the review, I fixed the 3 points you mentioned. |
Here is also an example how to resize with JS as its apparently now possible to style the icon https://stackoverflow.com/questions/35702705/is-there-a-way-to-change-the-css-resize-corners-position |
Thanks for fixing these things ;)
Hmm its not so well shown on video - but when the content tree is folded out the moving of the document tree is a bit laggier than when the content tree is hidden. The content tree itself is also quite smooth. simplescreenrecorder-2022-10-26_15.26.38.mp4One can fold the content tree to 0 height - but the js collapsed state is not changed. (Proposal: add a min-height or something) simplescreenrecorder-2022-10-26_15.31.29.mp4
;D lets talk about a strategy to fix #2691 once and for all maybe make it scrollable or break into two lines? if i remember correctly the html structure up there is horrible :D simplescreenrecorder-2022-10-26_15.34.27.mp4 |
No clue why, would need to check the browser performance tool
There is already a min-height of
Scroll often doesn't work properly with various input devices. |
Will check the pipeline, and we need a new version of |
df7be4f
to
406585f
Compare
Hmm not sure if I now break it but I can not resize the left side bar 🤷♂️ |
915096d
to
27c9712
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature... thanks for that.
Tested locally on Firefox, Chrome and Safari 💙
What I did
Made the Neos UI more responsive and flexible. This also brings the following features and benefits:
How I did it
Instead of having every ui layout component having absolute sizes and positions the base layout is now a CSS grid and each component has an area assigned. This way the whole layout can be controlled from the wrapping container.
How to verify it
Resolves: #3149