Fixes include when using matrix and strategy build. #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
include
of the matrix strategy was incorrectly handled.This simply appends the provided includes to the matrix product, s.t. this works (taken from the official doc)
Also replaces the comparison of the
commonKeysMatch()
with areflect.DeepEqual
to be able to compare maps.Potentially the entire loop could be replaced that way`
PS:
I do not know how testing works in this project, so I cannot easily add one. But I have seen, that neither
include
norexclude
appears to be tested.