Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: crash #535

Closed
jleonard-r7 opened this issue Feb 17, 2021 · 3 comments
Closed

Issue: crash #535

jleonard-r7 opened this issue Feb 17, 2021 · 3 comments
Labels
kind/bug Something isn't working stale

Comments

@jleonard-r7
Copy link

Act version

0.2.17


Expected behaviour

Does not crash.

Actual behaviour

Crashes.

10:32 $ act
panic: runtime error: comparing uncomparable type map[string]interface {}

goroutine 1 [running]:
github.com/nektos/act/pkg/model.commonKeysMatch(0xc000181500, 0xc0000aeba0, 0x4)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/pkg/model/workflow.go:198 +0x139
github.com/nektos/act/pkg/model.(*Job).GetMatrixes(0xc0000e5680, 0xc0000a5040, 0x6, 0xc0000e5680)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/pkg/model/workflow.go:180 +0x4b5
github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor(0xc00043b2c0, 0xc00043a4a0, 0x5)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/pkg/runner/runner.go:66 +0x52c
github.com/nektos/act/cmd.newRunCommand.func1(0xc0000aa000, 0x1e40218, 0x0, 0x0, 0x0, 0x0)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/cmd/root.go:202 +0x89c
github.com/spf13/cobra.(*Command).execute(0xc0000aa000, 0x1e40218, 0x0, 0x0, 0xc0000aa000, 0x1e40218)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/[email protected]/command.go:762 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0xc0000aa000, 0x0, 0x0, 0x8)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/[email protected]/command.go:852 +0x2fe
github.com/spf13/cobra.(*Command).Execute(...)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/[email protected]/command.go:800
github.com/nektos/act/cmd.Execute(0x19e8680, 0xc0003d8100, 0x19bf8b0, 0x6)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/cmd/root.go:57 +0xadb
main.main()
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/main.go:33 +0x175

Workflow and/or repository

workflow
name: example workflow

on: [push]

jobs:
  [...]

Steps to reproduce

  1. act

act output

10:32 $ act
panic: runtime error: comparing uncomparable type map[string]interface {}

goroutine 1 [running]:
github.com/nektos/act/pkg/model.commonKeysMatch(0xc000181500, 0xc0000aeba0, 0x4)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/pkg/model/workflow.go:198 +0x139
github.com/nektos/act/pkg/model.(*Job).GetMatrixes(0xc0000e5680, 0xc0000a5040, 0x6, 0xc0000e5680)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/pkg/model/workflow.go:180 +0x4b5
github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor(0xc00043b2c0, 0xc00043a4a0, 0x5)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/pkg/runner/runner.go:66 +0x52c
github.com/nektos/act/cmd.newRunCommand.func1(0xc0000aa000, 0x1e40218, 0x0, 0x0, 0x0, 0x0)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/cmd/root.go:202 +0x89c
github.com/spf13/cobra.(*Command).execute(0xc0000aa000, 0x1e40218, 0x0, 0x0, 0xc0000aa000, 0x1e40218)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/[email protected]/command.go:762 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0xc0000aa000, 0x0, 0x0, 0x8)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/[email protected]/command.go:852 +0x2fe
github.com/spf13/cobra.(*Command).Execute(...)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/[email protected]/command.go:800
github.com/nektos/act/cmd.Execute(0x19e8680, 0xc0003d8100, 0x19bf8b0, 0x6)
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/cmd/root.go:57 +0xadb
main.main()
/private/tmp/act-20201115-3464-1rimm85/act-0.2.17/main.go:33 +0x175

@jleonard-r7 jleonard-r7 added the kind/bug Something isn't working label Feb 17, 2021
@mumoshu
Copy link

mumoshu commented Feb 17, 2021

@jleonard-r7 I believe this is fixed via #415 and v0.2.18. Could you try again with v0.2.18 or greater?

@jleonard-r7
Copy link
Author

I installed via homebrew so am at the mercy of the package maintainers.

@github-actions
Copy link
Contributor

Issue is stale and will be closed in 14 days unless there is new activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants