Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mobile update link; robots.txt #185

Merged
merged 23 commits into from
Apr 14, 2020
Merged

fix: remove mobile update link; robots.txt #185

merged 23 commits into from
Apr 14, 2020

Conversation

leehanchung
Copy link
Member

Description

  • removed get mobile update link
  • adjusted robots.txt crawl delay

Type of change

Please delete options that are not relevant.

  • 🎨 CSS Styling fix
  • πŸš‘ Bug fix (non-breaking change which fixes an issue)
  • ♻️ πŸ—‘οΈ Re-factor, cleanup, un-comment, docstring
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change Status

  • 🏁 Complete, tested, ready to review and merge
  • πŸš₯ Complete, but not tested (may need new tests)
  • 🚧 WIP work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

  • Manually Functionality Testing
  • Unit Test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

Copy link
Contributor

@hurshd0 hurshd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member Author

@leehanchung leehanchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed. no glaring problems.

Copy link
Contributor

@elizabethts elizabethts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not run locally but approving BC HURSH IS IMPATIENT

@elizabethts elizabethts merged commit 2861ffe into master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants