Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: un commented get mobile sms updates #182

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Conversation

hurshd0
Copy link
Contributor

@hurshd0 hurshd0 commented Apr 13, 2020

Description

What Changed ? e.g. Github Issues Title or Trello Card Title

Type of change

Please delete options that are not relevant.

  • 🎨 CSS Styling fix
  • 🚑 Bug fix (non-breaking change which fixes an issue)
  • ♻️ 🗑️ Re-factor, cleanup, un-comment, docstring
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change Status

  • 🏁 Complete, tested, ready to review and merge
  • 🚥 Complete, but not tested (may need new tests)
  • 🚧 WIP work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

  • Manually Functionality Testing
  • Unit Test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

@hurshd0 hurshd0 changed the base branch from master to staging April 13, 2020 06:18
Copy link
Member

@leehanchung leehanchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ess emmmm esssss

@hurshd0 hurshd0 merged commit cb313fd into staging Apr 13, 2020
@leehanchung leehanchung deleted the adding-sms-button branch April 13, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants