Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👽 updated api calls for /stats route #70

Merged
merged 76 commits into from
Oct 10, 2020
Merged

👽 updated api calls for /stats route #70

merged 76 commits into from
Oct 10, 2020

Conversation

leehanchung
Copy link
Member

@leehanchung leehanchung commented Oct 10, 2020 •
edited
Loading

Description

👽 updated api calls for /stats route

Please describe it here... in EDIT mode.

Type of change

Please don't put a X mark here in EDIT mode

  • 🚑 Bug fix (non-breaking change which fixes an issue)
  • ♻️ 🗑️ Re-factor, cleanup, un-comment, docstring
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change Status

Please don't put a X mark here in EDIT mode

  • 🏁 Complete, tested, ready to review and merge
  • 🚥 Complete, but not tested (may need new tests)
  • 🚧 WIP work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

Please don't put a X mark here in EDIT mode

  • Manually Functionality Testing
  • Unit Test

Checklist

Please don't put a X mark here in EDIT mode

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

leehanchung and others added 30 commits April 11, 2020 00:43
@leehanchung
refactor: change Aaron to standard feat: adding basic test
0813a59 
- Changed APP to app according to Flask/FastAPI standard
- Changed config_ to _config. trailing space is for python default conflicts not import
- Adding basic tests for endpoints
@leehanchung
test: added test structures
936794c 
- 	est_app.py: testing �pp.py app title, description, version
- 	est_config.py: tested ProductionConfig, DevelopmentConfig, config loader
- 	est_endpoints.py: tested root test
@leehanchung
test: added test structures
73f9702 
- 	est_app.py: testing �pp.py app title, description, version
- 	est_config.py: tested ProductionConfig, DevelopmentConfig, config loader
- 	est_endpoints.py: tested root test
@leehanchung
tests: add testing for custom error messages
3d2957e
@hurshd0
chore: updated README
63920e4
@hurshd0
chore: fixed PR template
39861a5
@hurshd0
chore: updated README
d8cf68a
@hurshd0
Merge pull request #29 from ncov19-us/updating-readme
365f685 
chore: Updating readme
@hurshd0
chore: updated README
c678aa1
@hurshd0
Merge pull request #31 from ncov19-us/updating-readme
039a951 
chore: updated README
@leehanchung
tests: adds test cases for endpoints
de8046b 
- '/' done
- '/news' only testing for 422 and 405, no validation yet
- '/twitter': tested 422, 404, 405, and random data sample validation
- '/county': tested 404, 405, 422. no data return validation yet
- '/state': tested 405, 422.
- '/country': tested 405, 422.
- '/stats': tested 405, 422.
@leehanchung
style: fix for codefactor.
b1d9a68 
- 	est_config.py: keeping assert == True/False for code readability
- 	est_endpoints.py: keeping TODO as a reminder to fix endpoints.py
@leehanchung
style: changed config_ to �pp_config after technical discussion
b015b40
@leehanchung
chores: merge conflicts
0d92728
@leehanchung
style: chore:
ef9ad7b 
- added .pylintrc
- fixed all files for pylint
- added .github/workflow/pythonapp.yml
- added pipenv, pylint and pytest
@leehanchung
chore:
b240659 
- streamlining pythonapp.yml
- triggers pythonapp.yml on all push and pull_request
@leehanchung
chore: updated pythonapp.yml
6ae8efb
@leehanchung
chore: updated pythonapp.yml
ac65043
@leehanchung
chore: updated pythonapp.yml, readme.md
3555733
@leehanchung
chore: updated pythonapp.yml
16046e9
@leehanchung
chore: updated pythonapp.yml
599f829
@leehanchung
chore: updated pythonapp.yml
953819f
@leehanchung
chore: updated pythonapp.yml
2e4878a
@leehanchung
chore: updated pythonapp.yml
195adef
@leehanchung
chore: updated pythonapp.yml
b34702e
@leehanchung
chore: updated pythonapp.yml
85e70b9
@leehanchung
chore: updated pythonapp.yml
fd17da6
@hurshd0
Merge pull request #37 from ncov19-us/tests
0382ae8 
test: chore: refactor: feat:
@leehanchung
feat: rerouting root endpoint to postman
d7b72e1
@leehanchung
feat: rerouting root endpoint to postman
521b455
hurshd0 and others added 28 commits April 13, 2020 21:15
@hurshd0
chore: updating license
0567e84
@hurshd0
Merge pull request #44 from ncov19-us/hurshd0-patch-1
317ab6c 
chore: updating license, and merged staging changes
@hurshd0
chore: updating README again 🤧 (#46)
2600054 
* chore: updating READMEs

* chore: updating READMEs
@hurshd0
chore: updating READMEs
52554b4
@hurshd0
chore: updating READMEs (#48)
979ff02
@leehanchung
fix: post county new_death nan error (#50)
729f1c6 
* fix: /post county new_death nan error

* fix: /post county new_death nan error
@leehanchung
feat: test: (#52)
96e39bd 
* feat: adding zip route

* feat: zip route #1

* feat: removed uszipcode, added zipcodes

* feat:
- feat: added zip endpoint to return county data given zip code
- test: added tests for the zip endpoint
- feat: modified github actions to trigger on push, and on pr to master/staging

* han: attempt to fix codefactor #1

* feat: zip endpoint
- added custom exception handlers
- mal-formed zip codes now return 422 instead of 404
- changed mal-formed zip codes test cases from 404 to 422
@hurshd0
fixed zip endpoint for nyc (#54)
53fa1e0
@hurshd0
Merge branch 'master' into staging
f53a1bb
@leehanchung @hurshd0
fix: benton, wa
636a31d
@leehanchung @hurshd0
fix: github actions
354f069
@leehanchung @hurshd0
fix: github actions to pr only
14f963e
@leehanchung @hurshd0
fix: combined -- counties and retargeted combined counties (#57)
44d3d84 
* chore: updating master (#55)

* refactor: change Aaron to standard feat: adding basic test
- Changed APP to app according to Flask/FastAPI standard
- Changed config_ to _config. trailing space is for python default conflicts not import
- Adding basic tests for endpoints

* test: added test structures
- 	est_app.py: testing �pp.py app title, description, version
- 	est_config.py: tested ProductionConfig, DevelopmentConfig, config loader
- 	est_endpoints.py: tested root test

* test: added test structures
- 	est_app.py: testing �pp.py app title, description, version
- 	est_config.py: tested ProductionConfig, DevelopmentConfig, config loader
- 	est_endpoints.py: tested root test

* tests: add testing for custom error messages

* chore: updated README

* chore: fixed PR template

* chore: updated README

* chore: updated README

* tests: adds test cases for endpoints
- '/' done
- '/news' only testing for 422 and 405, no validation yet
- '/twitter': tested 422, 404, 405, and random data sample validation
- '/county': tested 404, 405, 422. no data return validation yet
- '/state': tested 405, 422.
- '/country': tested 405, 422.
- '/stats': tested 405, 422.

* style: fix for codefactor.
- 	est_config.py: keeping assert == True/False for code readability
- 	est_endpoints.py: keeping TODO as a reminder to fix endpoints.py

* style: changed config_ to �pp_config after technical discussion

* style: chore:
- added .pylintrc
- fixed all files for pylint
- added .github/workflow/pythonapp.yml
- added pipenv, pylint and pytest

* chore:
- streamlining pythonapp.yml
- triggers pythonapp.yml on all push and pull_request

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml, readme.md

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* feat: rerouting root endpoint to postman

* feat: rerouting root endpoint to postman

* feat: added redirect to postman, added test

* fix: added uvloop

* feat: adding coverall

* feat: installed coveralls for coverall.io

* feat: installed coveralls for coverall.io

* feat: installed coveralls for coverall.io

* feat: installed coveralls for coverall.io attempt 6

* feat: installed coveralls for coverall.io attempt 8

* feat: installed coveralls for coverall.io attempt 9

* feat: settingup coverall attempt #11

* feat: coverall badge attempt #12

* feat: coverall added, feat: routing root to redoc

* fix: default config logic

* fix: default config logic

* Update LICENSE

* chore: updating README again  🤧 (#46)

* chore: updating READMEs

* chore: updating READMEs

* chore: updating READMEs (#48)

* fix: post county new_death nan error (#50)

* fix: /post county new_death nan error

* fix: /post county new_death nan error

* feat: test: (#52)

* feat: adding zip route

* feat: zip route #1

* feat: removed uszipcode, added zipcodes

* feat:
- feat: added zip endpoint to return county data given zip code
- test: added tests for the zip endpoint
- feat: modified github actions to trigger on push, and on pr to master/staging

* han: attempt to fix codefactor #1

* feat: zip endpoint
- added custom exception handlers
- mal-formed zip codes now return 422 instead of 404
- changed mal-formed zip codes test cases from 404 to 422

* fixed zip endpoint for nyc (#54)

Co-authored-by: leehanchung <[email protected]>
Co-authored-by: Hanchung Lee <[email protected]>

* fix: benton, wa

* fix: github actions

* fix: github actions to pr only

* fix: counties yo counties

* fix: merge confliictassz round 2

Co-authored-by: Harsh Desai <[email protected]>
@leehanchung @hurshd0
chore: updating master (#55) (#59)
5110ec4 
* refactor: change Aaron to standard feat: adding basic test
- Changed APP to app according to Flask/FastAPI standard
- Changed config_ to _config. trailing space is for python default conflicts not import
- Adding basic tests for endpoints

* test: added test structures
- 	est_app.py: testing �pp.py app title, description, version
- 	est_config.py: tested ProductionConfig, DevelopmentConfig, config loader
- 	est_endpoints.py: tested root test

* test: added test structures
- 	est_app.py: testing �pp.py app title, description, version
- 	est_config.py: tested ProductionConfig, DevelopmentConfig, config loader
- 	est_endpoints.py: tested root test

* tests: add testing for custom error messages

* chore: updated README

* chore: fixed PR template

* chore: updated README

* chore: updated README

* tests: adds test cases for endpoints
- '/' done
- '/news' only testing for 422 and 405, no validation yet
- '/twitter': tested 422, 404, 405, and random data sample validation
- '/county': tested 404, 405, 422. no data return validation yet
- '/state': tested 405, 422.
- '/country': tested 405, 422.
- '/stats': tested 405, 422.

* style: fix for codefactor.
- 	est_config.py: keeping assert == True/False for code readability
- 	est_endpoints.py: keeping TODO as a reminder to fix endpoints.py

* style: changed config_ to �pp_config after technical discussion

* style: chore:
- added .pylintrc
- fixed all files for pylint
- added .github/workflow/pythonapp.yml
- added pipenv, pylint and pytest

* chore:
- streamlining pythonapp.yml
- triggers pythonapp.yml on all push and pull_request

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml, readme.md

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* chore: updated pythonapp.yml

* feat: rerouting root endpoint to postman

* feat: rerouting root endpoint to postman

* feat: added redirect to postman, added test

* fix: added uvloop

* feat: adding coverall

* feat: installed coveralls for coverall.io

* feat: installed coveralls for coverall.io

* feat: installed coveralls for coverall.io

* feat: installed coveralls for coverall.io attempt 6

* feat: installed coveralls for coverall.io attempt 8

* feat: installed coveralls for coverall.io attempt 9

* feat: settingup coverall attempt #11

* feat: coverall badge attempt #12

* feat: coverall added, feat: routing root to redoc

* fix: default config logic

* fix: default config logic

* Update LICENSE

* chore: updating README again  🤧 (#46)

* chore: updating READMEs

* chore: updating READMEs

* chore: updating READMEs (#48)

* fix: post county new_death nan error (#50)

* fix: /post county new_death nan error

* fix: /post county new_death nan error

* feat: test: (#52)

* feat: adding zip route

* feat: zip route #1

* feat: removed uszipcode, added zipcodes

* feat:
- feat: added zip endpoint to return county data given zip code
- test: added tests for the zip endpoint
- feat: modified github actions to trigger on push, and on pr to master/staging

* han: attempt to fix codefactor #1

* feat: zip endpoint
- added custom exception handlers
- mal-formed zip codes now return 422 instead of 404
- changed mal-formed zip codes test cases from 404 to 422

* fixed zip endpoint for nyc (#54)

Co-authored-by: leehanchung <[email protected]>
Co-authored-by: Hanchung Lee <[email protected]>

Co-authored-by: Harsh Desai <[email protected]>
@leehanchung
Merge branch 'master' into staging
256f183
@leehanchung
Merge branch 'master' into staging
92716e3
@hurshd0
fix: zipcode fix for us districts and territories
e08cf8b
@hurshd0
tests: unit test for US districts and all territories added
2857b8d
@hurshd0
chore: linting fixed
76b07da
@hurshd0
fix: merge conflict resolved with staging
2136f00
@leehanchung
Merge branch 'staging' of https://github.com/ncov19-us/back-end into …
8fe6568 
…staging
@leehanchung @hurshd0
style: pylint and fix panda warning
8895bb9
@leehanchung @hurshd0
chore: more linting
ac47045
@hurshd0
Merge branch 'master' into staging
7ddc97c
@hurshd0
chore: temp pylint removed from the github workflow
d43c911
@leehanchung
fix: post stats endpoint error
7e27e87 
refactor: added black formatter and bring back linting
@leehanchung
👽 updated api calls for /stats route
ac86bd6
@leehanchung
Merge branch 'master' into staging
6d9a508
@leehanchung leehanchung temporarily deployed to ncov19-covid-staging-sauqvt7lh October 10, 2020 17:54 Inactive
@leehanchung leehanchung merged commit 914d943 into master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leehanchung @hurshd0