test: chore: refactor: feat: #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed APP to app according to Flask/FastAPI standard - Changed config_ to _config. trailing space is for python default conflicts not import - Adding basic tests for endpoints
- est_app.py: testing �pp.py app title, description, version - est_config.py: tested ProductionConfig, DevelopmentConfig, config loader - est_endpoints.py: tested root test
- est_app.py: testing �pp.py app title, description, version - est_config.py: tested ProductionConfig, DevelopmentConfig, config loader - est_endpoints.py: tested root test
- '/' done - '/news' only testing for 422 and 405, no validation yet - '/twitter': tested 422, 404, 405, and random data sample validation - '/county': tested 404, 405, 422. no data return validation yet - '/state': tested 405, 422. - '/country': tested 405, 422. - '/stats': tested 405, 422.
- est_config.py: keeping assert == True/False for code readability - est_endpoints.py: keeping TODO as a reminder to fix endpoints.py
- added .pylintrc - fixed all files for pylint - added .github/workflow/pythonapp.yml - added pipenv, pylint and pytest
hurshd0
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What Changed ? e.g. Github Issues Title or Trello Card Title
Type of change
Please delete options that are not relevant.
Change Status
How Has This Been Tested?
Checklist