chore: updating master from staging #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed APP to app according to Flask/FastAPI standard - Changed config_ to _config. trailing space is for python default conflicts not import - Adding basic tests for endpoints
- est_app.py: testing οΏ½pp.py app title, description, version - est_config.py: tested ProductionConfig, DevelopmentConfig, config loader - est_endpoints.py: tested root test
- est_app.py: testing οΏ½pp.py app title, description, version - est_config.py: tested ProductionConfig, DevelopmentConfig, config loader - est_endpoints.py: tested root test
chore: Updating readme
chore: updated README
- '/' done - '/news' only testing for 422 and 405, no validation yet - '/twitter': tested 422, 404, 405, and random data sample validation - '/county': tested 404, 405, 422. no data return validation yet - '/state': tested 405, 422. - '/country': tested 405, 422. - '/stats': tested 405, 422.
- est_config.py: keeping assert == True/False for code readability - est_endpoints.py: keeping TODO as a reminder to fix endpoints.py
- added .pylintrc - fixed all files for pylint - added .github/workflow/pythonapp.yml - added pipenv, pylint and pytest
test: chore: refactor: feat:
fix: uvloop issue on heroku; feat: rerouting base env
feat: coverall; feat: coverall and github action badges; feat: rerout to redoc
fix: config fix
chore: updating license, and merged staging changes
leehanchung
added a commit
that referenced
this pull request
Apr 30, 2020
fix: default config logic chore: updating README again π€§ (#46) * chore: updating READMEs * chore: updating READMEs chore: updating master from staging (#45) * refactor: change Aaron to standard feat: adding basic test - Changed APP to app according to Flask/FastAPI standard - Changed config_ to _config. trailing space is for python default conflicts not import - Adding basic tests for endpoints * test: added test structures - est_app.py: testing οΏ½pp.py app title, description, version - est_config.py: tested ProductionConfig, DevelopmentConfig, config loader - est_endpoints.py: tested root test * test: added test structures - est_app.py: testing οΏ½pp.py app title, description, version - est_config.py: tested ProductionConfig, DevelopmentConfig, config loader - est_endpoints.py: tested root test * tests: add testing for custom error messages * chore: updated README * chore: fixed PR template * chore: updated README * chore: updated README * tests: adds test cases for endpoints - '/' done - '/news' only testing for 422 and 405, no validation yet - '/twitter': tested 422, 404, 405, and random data sample validation - '/county': tested 404, 405, 422. no data return validation yet - '/state': tested 405, 422. - '/country': tested 405, 422. - '/stats': tested 405, 422. * style: fix for codefactor. - est_config.py: keeping assert == True/False for code readability - est_endpoints.py: keeping TODO as a reminder to fix endpoints.py * style: changed config_ to οΏ½pp_config after technical discussion * style: chore: - added .pylintrc - fixed all files for pylint - added .github/workflow/pythonapp.yml - added pipenv, pylint and pytest * chore: - streamlining pythonapp.yml - triggers pythonapp.yml on all push and pull_request * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml, readme.md * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml * chore: updated pythonapp.yml * feat: rerouting root endpoint to postman * feat: rerouting root endpoint to postman * feat: added redirect to postman, added test * fix: added uvloop * feat: adding coverall * feat: installed coveralls for coverall.io * feat: installed coveralls for coverall.io * feat: installed coveralls for coverall.io * feat: installed coveralls for coverall.io attempt 6 * feat: installed coveralls for coverall.io attempt 8 * feat: installed coveralls for coverall.io attempt 9 * feat: settingup coverall attempt #11 * feat: coverall badge attempt #12 * feat: coverall added, feat: routing root to redoc * fix: default config logic * fix: default config logic * Update LICENSE Co-authored-by: leehanchung <[email protected]> chore: updating READMEs (#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lot of things are changed
Type of change
Please delete options that are not relevant.
Change Status
How Has This Been Tested?
Checklist