Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate 20200121 #28

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Integration Candidate 20200121 #28

merged 4 commits into from
Jan 27, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 21, 2020

Describe the contribution
Fix #23, fix #24

Testing performed
Steps taken to test the contribution:

  1. Current CI passes
  2. Enhanced CI in Fix #30, Apply standard style #40 passes debug/with deprecated elements testing

Expected behavior changes

  • Corrected syslog writes
  • Fixed return handling from CFE_TBL_GitAddress

System(s) tested on

  • CI: Ubuntu 18.04

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

jphickey and others added 4 commits January 9, 2020 10:14
1. Do not use the backslash to split string literal across lines.
2. Add casting to make the code work on both 32-bit and 64-bit platforms.
This is a valid return from this function.
Accept CFE_SUCCESS from CFE_TBL_GetAddress()
@skliper skliper added this to the 2.4.0 milestone Jan 21, 2020
@skliper
Copy link
Contributor Author

skliper commented Jan 27, 2020

CCB 20200122 - Reviewd and approved for merge to master

@skliper skliper merged commit f1acbd9 into master Jan 27, 2020
@skliper skliper deleted the ic-20200121 branch January 27, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_TBL_GetAddress() may return CFE_SUCCESS Improper calls to CFE_ES_WriteSysLog
2 participants