Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper calls to CFE_ES_WriteSysLog #23

Closed
jphickey opened this issue Jan 9, 2020 · 0 comments · Fixed by #28
Closed

Improper calls to CFE_ES_WriteSysLog #23

jphickey opened this issue Jan 9, 2020 · 0 comments · Fixed by #28
Labels
bug Something isn't working
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Jan 9, 2020

Describe the bug
At some point some extra writes to the syslog were added, for example:

       CFE_ES_WriteToSysLog("SCHEULE APP: Error Releasing Table \
                             SCH_LAB_SchTbl, RC = 0x%08X\n", Status);

There are two issues:

  1. Use of the "line-continuation" backslash to split across lines -- note this does not remove the leading whitespace on the next line, so the actual literal result will have a large space in it.
  2. Lack of a cast on the parameter. This causes build failure on platforms where int32 is actually a long, not int.

To Reproduce
Build for a 32-bit platform. Triggers a warning about the incorrect argument type.

Expected behavior
Should build cleanly on a 32-bit platform.

System observed on:
Ubuntu 18.04 LTS 64-bit build host, building for i686-rtems4.11 target.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit that referenced this issue Jan 9, 2020
1. Do not use the backslash to split string literal across lines.
2. Add casting to make the code work on both 32-bit and 64-bit platforms.
@astrogeco astrogeco added the bug Something isn't working label Oct 1, 2020
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants