Fix #506, enforce nonzero stack size #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve inconsistency in how the stack size is treated across different OS implemntations. POSIX would enforce a minimum, where RTEMS would not. With this change the user requested size is passed through to the underlying OS exactly as is, no enforced minimum. An additional sanity check is added at the shared layer to ensure that the stack size is never passed as 0.
skliper
approved these changes
Jun 16, 2020
|
CCB 2020-06-17: APPROVED |
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Jun 29, 2020
The pthread_attr_setstacksize() function stipulates that it may fail if the user-supplied stack size is not at least PTHREAD_STACK_MIN and also possibly a multiple of page size. This partially reverts previous PR nasa#508 and adds back rounding up to PTHREAD_STACK_MIN and also adds rounding up to a system page size. However the check for zero stack still remains at the shared level so attempts to create a task with zero stack will still fail. This allows internal helper threads to be created with a default minimum stack size, however.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Jun 30, 2020
The pthread_attr_setstacksize() function stipulates that it may fail if the user-supplied stack size is not at least PTHREAD_STACK_MIN and also possibly a multiple of page size. This partially reverts previous PR nasa#508 and adds back rounding up to PTHREAD_STACK_MIN and also adds rounding up to a system page size. However the check for zero stack still remains at the shared level so attempts to create a task with zero stack will still fail. This allows internal helper threads to be created with a default minimum stack size, however.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Resolve inconsistency in how the stack size is treated across different OS implemntations. POSIX would enforce a minimum, where RTEMS would not.
With this change the user requested size is passed through to the underlying OS exactly as is, no enforced minimum.
An additional sanity check is added at the shared layer to ensure that the stack size is never passed as 0.
Fixes #506
Testing performed
Build and execute CFE and sanity test
Build and execute all unit tests.
Also tested creating a task with zero stack size and confirm error is generated on Linux.
Expected behavior changes
The
idmap-api-testpasses on RTEMS.Attempting to create a task with zero stack now will result in error.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3 via QEMU/pc686
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.