Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idmap API test needs to use real task stack size and priority #506

Closed
jphickey opened this issue Jun 16, 2020 · 0 comments · Fixed by #508 or #521
Closed

Idmap API test needs to use real task stack size and priority #506

jphickey opened this issue Jun 16, 2020 · 0 comments · Fixed by #508 or #521
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Describe the bug
Although Linux allows the stack size to be zero (it uses a nonzero default) other OS's do not have this fallback. The idmap-api-test attempts to create a task with zero stack and this fails on RTEMS.

To Reproduce
Run 'idmap-api-teston RTEMS. OS_TaskCreate()` fails (reports as TSF) but then other failures occur related to this.

Expected behavior
Should pass.

System observed on:
RTEMS 4.11.3 running in QEMU.

Additional context
Should consider forcibly making every OS fail (i.e. enforce in shared layer) if passed a zero stack.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 16, 2020
@jphickey jphickey added the bug label Jun 16, 2020
jphickey added a commit to jphickey/osal that referenced this issue Jun 16, 2020
@jphickey
Fix nasa#506, enforce nonzero stack size
d6bf132 
Resolve inconsistency in how the stack size is treated across
different OS implemntations.  POSIX would enforce a minimum,
where RTEMS would not.

With this change the user requested size is passed through
to the underlying OS exactly as is, no enforced minimum.

An additional sanity check is added at the shared layer to
ensure that the stack size is never passed as 0.
@jphickey jphickey mentioned this issue Jun 16, 2020
Merged
astrogeco added a commit that referenced this issue Jun 23, 2020
@astrogeco
Merge pull request #508 from jphickey/fix-506-task-stacksize
0689616 
Fix #506, enforce nonzero stack size
@astrogeco astrogeco mentioned this issue Jun 23, 2020
Merged
@jphickey jphickey mentioned this issue Jun 29, 2020
Closed
@skliper skliper modified the milestones: 6.0.0, v5.1.0 Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#506 - Update API documentation
e403929
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#507 from skliper/fix506-api-doc-scrub
f09808f 
Fix nasa#506 - Update API documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #506, enforce nonzero stack size jphickey/osal
Integration candidate: 2020-06-17 nasa/osal
2 participants
@jphickey @skliper