Fix #1398, separate bind and listen calls for streams #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OS_SocketBindAddress() and OS_SocketListen() to allow users to bind an address without also calling listen(). The use case is for client side connections where the source port needs to be controlled.
| * See description in API and header file for detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| int32 OS_SocketBindAddress(osal_id_t sock_id, const OS_SockAddr_t *Addr) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * Generated stub function for OS_SocketBindAddress() | ||
| * ---------------------------------------------------- | ||
| */ | ||
| int32 OS_SocketBindAddress(osal_id_t sock_id, const OS_SockAddr_t *Addr) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * See description in API and header file for detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| int32 OS_SocketListen(osal_id_t sock_id) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * Generated stub function for OS_SocketListen() | ||
| * ---------------------------------------------------- | ||
| */ | ||
| int32 OS_SocketListen(osal_id_t sock_id) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| * See prototype for argument/return detail | ||
| * | ||
| *-----------------------------------------------------------------*/ | ||
| int32 OS_SocketListen_Impl(const OS_object_token_t *token) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -214,16 +214,14 @@ | |||
| * See prototype for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 OS_SocketBind_Impl(const OS_object_token_t *token, const OS_SockAddr_t *Addr) | |||
| int32 OS_SocketBindAddress_Impl(const OS_object_token_t *token, const OS_SockAddr_t *Addr) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 27, 2023
*Combines:* cFE v7.0.0-rc4+dev356 osal v6.0.0-rc4+dev223 **Includes:** *cFE* - nasa/cFE#2416 *osal* - nasa/osal#1397 - nasa/osal#1399 Co-authored by: Joseph Hickey <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 27, 2023
*Combines:* cFE v7.0.0-rc4+dev356 osal v6.0.0-rc4+dev223 **Includes:** *cFE* - nasa/cFE#2416 *osal* - nasa/osal#1397 - nasa/osal#1399 Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Add OS_SocketBindAddress() and OS_SocketListen() to allow users to bind an address without also calling listen(). The use case is for client side connections where the source port needs to be controlled.
Fixes #1398
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Users can call
OS_SocketBindAddress()to bind a specific port/address for client-side connectionsSystem(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.