Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2415, use correct object extension in table build #2416

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Do not assume ".o" for object files, use ${CMAKE_C_OUTPUT_EXTENSION}

Fixes #2415

Testing performed
Build tables for VxWorks (using .obj extension)

Expected behavior changes
Build should succeed now

System(s) tested on
GSFC VxWorks build host

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Do not assume ".o" for object files, use ${CMAKE_C_OUTPUT_EXTENSION}
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 26, 2023
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jul 27, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 27, 2023
*Combines:*

cFE v7.0.0-rc4+dev356
osal v6.0.0-rc4+dev223

**Includes:**

*cFE*
- nasa/cFE#2416

*osal*
- nasa/osal#1397
- nasa/osal#1399

Co-authored by: Joseph Hickey <[email protected]>
@dzbaker dzbaker mentioned this pull request Jul 27, 2023
2 tasks
@dzbaker dzbaker merged commit c99accc into nasa:main Jul 27, 2023
21 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 27, 2023
*Combines:*

cFE v7.0.0-rc4+dev356
osal v6.0.0-rc4+dev223

**Includes:**

*cFE*
- nasa/cFE#2416

*osal*
- nasa/osal#1397
- nasa/osal#1399

Co-authored by: Joseph Hickey <[email protected]>
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 3, 2023
@jphickey jphickey deleted the fix-2415-tblobj-extension branch November 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB Equuleus-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table build logic is assuming ".o" extension for object files
3 participants