Integration Candidate 2020-03-25 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skliper https://travis-ci.com/github/nasa/cFS/jobs/311547104 |
|
This is a merge issue - the global variable was renamed from Sample_AppData to SAMPLE_AppData to adhere to the capitalization patterns used in other units and the naming convention. |
added 3 commits
April 3, 2020 14:23
Rejecting nasa/cFE#533 which was merged into cFE's integration candidate
44cc213
to
13b7e08
Compare
added 2 commits
April 3, 2020 16:53
Change provider to pages Set strategy to git
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Entity IDs should be larger by default for real-world applicability, as this also restricts what CFDP can receive, not just what it sends. Note CFDP will only use the number of bytes required to express the value, so values less than 256 will still only use 1 byte, regardless of this config. This just allows use of larger values.
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Fix nasa#62, make entity ID default to 32 bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate 2020-03-25,
incorporates changes to sample_app, cFE, and OSAL
Fix #28, #60, and #47,
Testing performed
PR #61
Bundle CI
Expected behavior changes
See related Integration Candidate PRs
nasa/osal#52
nasa/osal#401
nasa/cFE#579
Updates to Bundle CI:
System(s) tested on
Bundle CI - Ubuntu:Bionic
Code contibutions
Jacob Hageman - NASA/GSFC
Gerardo E. Cruz-Ortiz - NASA/GSFC