Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for deploy docs, warnings, and simplify #61

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 28, 2020

Describe the contribution
Fix #28, Deploy documentation
Fix #60, config warnings except for the new ones
introduced by using the latest deployment version
Fix #47, removes permissive mode hack and updates README.md
Adds enforce of no doxygen warnings for osal and users guide

Testing performed
Steps taken to test the contribution:

  1. CI test

Expected behavior changes
Old CI script warnings resolved (2 remain based on using development version)
Now enforces no doxygen warnings for user guides
Will deploy documentation to gh_pages branch on push to master

System(s) tested on

  • CI system

Additional context
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

astrogeco and others added 2 commits March 27, 2020 10:16
Fix nasa#28, Deploy documentation
Fix nasa#60, config warnings except for the new ones
introduced by using the latest deployment version
Fix nasa#47, removes permissive mode hack and updates README.md
Adds enforce of no doxygen warnings for osal and users guide
@skliper skliper self-assigned this Mar 28, 2020
@skliper
Copy link
Contributor Author

skliper commented Mar 28, 2020

@astrogeco @jphickey could you review and merge this? All just CI/README changes, and once this is in I can update the README to reference the deployment documentation (adds the cFE and OSAL user's guide auto-generated pdfs). NOTE - I did only test it in my fork w/ special settings to make it work. There is a chance it may fail the CI check on merge to master by another user, but I'll work with whoever does it to solve it ASAP. Likely failure case could be the GITHUB_TOKEN, but documentation says collaborators should have access to mine.

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems OK. One minor comment/question noted in the docs build.

.travis.yml Show resolved Hide resolved
@astrogeco astrogeco changed the base branch from master to integration-candidate April 1, 2020 04:27
@astrogeco astrogeco merged commit 69cff7f into nasa:integration-candidate Apr 1, 2020
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
@skliper skliper deleted the fix28-deploy-docs branch January 28, 2021 23:01
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Removes the "optimization" for big endian, unlikely to be useful.
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Fix nasa#61, remove dependence on ENDIAN macro for checksum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants