Fix #828, Spacecraft ID sample set to historical value (0x42) #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 4, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This is a copy of #829 but targeting 7.0 (main development branch via the integration-candidate)
Fix #828 - set spacecraft ID in sample targets.cmake to 0x42
Testing performed
Nominal build and test
Expected behavior changes
Spacecraft ID back to historical value (some toolchains depend on it). Verified at PSP startup, reported as 66 (0x42).
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC