Fix #265, implement cmake name based targets #776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Allow targets to be configured in
targets.cmake
by name, rather than a numeric index. This is more user friendly, allows more configuration flexibility, and cleans up a bunch of extra logic too.Fixes #265
Testing performed
Build system, sanity check CFE, and run all unit tests
Testing not fully completed - Initially submitting PR for design review/feedback.
Expected behavior changes
No change to FSW, but changes the way targets are defined in
targets.cmake
.This includes backward compatibility for existing files/configs, however.
System(s) tested on
Ubuntu 20.04
Additional context
Also related to #710, this cleans up hardcoded CPU IDs that were in the platform config header file.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.